Replace hardcoded time units with named constants#861
Closed
Minku-Koo wants to merge 6 commits intopython-pendulum:masterfrom
Closed
Replace hardcoded time units with named constants#861Minku-Koo wants to merge 6 commits intopython-pendulum:masterfrom
Minku-Koo wants to merge 6 commits intopython-pendulum:masterfrom
Conversation
Contributor
Minku-Koo
commented
Nov 17, 2024
Minku-Koo
commented
- Replaced hardcoded time-related values with named constants.
- Facilitates easier adjustments of these values and reduces potential for errors.|
- Replaced hardcoded time-related values with named constants. - Facilitates easier adjustments of these values and reduces potential for errors.|
CodSpeed Performance ReportMerging #861 will not alter performanceComparing Summary
|
- Constants declared outside the class should be directly accessed without using `self`.
Contributor
Author
|
@Secrus plz check it |
Collaborator
|
Fix pre-commit checks, please. |
- Ensured all files pass pre-commit checks - Fixed line length violations (E501) in `difference_formatter.py`
Contributor
Author
|
I fix pre-commit, but there is some problem about rust. |
Collaborator
|
Those issues are not present on the master branch, so I assume they are connected to your changes. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.